Remove last Closure from Block Factory. #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves UI, but is still pretty clunky. For example there’s still not way to choose “no colour”. Closes #668.
Near complete rewrite of colour picker for Blockly Factory. * Drop IE6 support. * Flip picker as needed so it doesn’t go offscreen. * Add support for no colour. * Factor CSS out of JS. * Provide palette of our standard colours.
Previously they were defined in hex. This meant that saturation and value were hardcoded. This also resulted in off-by-one errors (Math was hardcoded as #5C68A6, but is calculated as #5B67A5) which in turn resulted in the colour not being highlighted in the picker.
Sigh.
RoboErikG
reviewed
Jun 24, 2019
RoboErikG
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves UI, allows "no colour" to be set, but is still pretty clunky. Closes #668.