Fix width on dummy row. #2947
Merged
Fix width on dummy row. #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Padding was never added on rows with only dummy inputs.
Proposed Changes
New:
Old:
Additional information
If a row has only a dummy input it will always align left, even if the dummy input actually said to align right. This seems subpar, although it probably matches the old behaviour.
I didn't actually create a Measurable for a dummy input, since it's never drawn, but that means we don't have a way to find the Blockly.Input that owns this row's fields, and that means we can't tell which way to align stuff.
That's similar to this problem: #338
That makes me wonder if I need an Input measurable for dummy inputs.