Move the dropdown field into the dropdown div. #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samelhusseini
commented
Sep 27, 2019
|
|
||
| '.blocklyDropDownDiv .goog-menuitem-highlight,', | ||
| '.blocklyDropDownDiv .goog-menuitem-hover {', | ||
| 'background-color: rgba(0,0,0,.2);', |
There was a problem hiding this comment.
We don't use goog-menuitem-hover
core/dropdowndiv.js
Outdated
| @@ -185,10 +201,16 @@ Blockly.DropDownDiv.clearContent = function() { | |||
| * Set the colour for the drop-down. | |||
| * @param {string} backgroundColour Any CSS colour for the background. | |||
| * @param {string} borderColour Any CSS colour for the border. | |||
| * @param {boolean=} opt_invertedText Whether or not the text color should be | |||
There was a problem hiding this comment.
Why opt_invertedText instead of opt_className?
There was a problem hiding this comment.
I was hoping to just provide the two options, and that was a way to indicate whether or not the color needs inverted text or not.
I will leave this out of this PR though, and think about it a little more.
rachel-fenichel
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Last (dropdown) field still using the widget div.
Proposed Changes
Render the dropdown field in the dropdown div.
Add default colors to the dropdown div, so that each owner that doesn't care about setting the color doesn't need to set default colors. (We should think about how this ties into themes).
Added support for inverted text (white text with colored background), by default resorting to black text for the white default background.
Reason for Changes
Test Coverage
Tested playground.
Tested on:
Documentation
Additional Information