October 2019 release candidate (Q3 2019)

.eslintignore

@@ -1,18 +1,18 @@
 *_compressed*.js
 *_uncompressed*.js
-blockly_node_javascript_en.js
 gulpfile.js
 /msg/*
-/core/css.js
+/core/utils/global.js
 /tests/blocks/*
 /tests/compile/*
 /tests/jsunit/*
 /tests/generators/*
 /tests/mocha/run_mocha_tests_in_browser.js
+/tests/screenshot/*
 /tests/test_runner.js
 /tests/workspace_svg/*
 /generators/*
 /demos/*
-/accessible/*
 /appengine/*
 /externs/*
+/closure/*

.eslintrc.json

@@ -54,8 +54,10 @@
         "_comment": "Blockly uses single quotes except for JSON blobs, which must use double quotes.",
         "quotes": ["off"],
         "semi": ["error", "always"],
-        "_comment": "Blockly doesn't have space before function paren",
+        "_comment": "Blockly doesn't have space before function paren when defining functions",
         "space-before-function-paren": ["error", "never"],
+        "_comment": "Blocklydoesn't have space before function paren when calling functions",
+        "func-call-spacing": ["error", "never"],
         "space-infix-ops": ["error"],
         "_comment": "Blockly uses 'use strict' in files",
         "strict": ["off"],
@@ -64,7 +66,15 @@
         "_comment": "Closure style allows redeclarations",
         "no-redeclare": ["off"],
         "valid-jsdoc": ["error", {"requireReturn": false}],
-        "no-console": ["off"]
+        "no-console": ["off"],
+        "no-multi-spaces": ["error", { "ignoreEOLComments": true }],
+        "operator-linebreak": ["error", "after"],
+        "spaced-comment": ["error", "always", {
+            "block": {
+                "balanced": true
+            },
+            "exceptions": ["*"]
+        }]
     },
     "env": {
         "browser": true

.gitignore

@@ -1,15 +1,19 @@
-blockly_node_javascript_en.js
 node_modules
 npm-debug.log
+build-debug.log
 .DS_Store
 .settings
 .project
+*.gz
 *.pyc
 *.komodoproject
 /nbproject/private/
 
 tests/compile/main_compressed.js
 tests/compile/*compiler*.jar
+tests/screenshot/outputs/*
 local_build/*compiler*.jar
 local_build/local_*_compressed.js
-dist/
+chromedriver
+typings/tmp/*
+dist/

.travis.yml

@@ -1,28 +1,24 @@
 language: node_js
 os: linux
-dist: trusty
+dist: xenial
 node_js:
   - 8
   - 10
 addons:
+  chrome: stable
   firefox: latest
-  apt:
-    packages:
-    - google-chrome-stable
     # TODO (#2114): reenable osx build.
     # - os: osx
     #   node_js: stable
     #   osx_image: xcode8.3
     #   addons:
     #     firefox: latest
-
+env:
+  - TRAVIS_CI=true
 before_script:
-  # Symlink closure library used by test/jsunit
-  - ln -s $(npm root)/google-closure-library ../closure-library
   - export DISPLAY=:99.0
   - if [ "${TRAVIS_OS_NAME}" == "linux" ]; then ( tests/scripts/setup_linux_env.sh ) fi
   - if [ "${TRAVIS_OS_NAME}" == "osx" ]; then ( tests/scripts/setup_osx_env.sh ) fi
   - sleep 2
-
 script:
-  - tests/run_all_tests.sh
+  - npm run test:run

LICENSE

@@ -1,6 +1,6 @@
 
                                  Apache License
-                           Version 2.0, January 2011
+                           Version 2.0, January 2004
                         http://www.apache.org/licenses/
 
    TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
@@ -175,3 +175,28 @@
       of your accepting any such warranty or additional liability.
 
    END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

README.md

@@ -8,10 +8,10 @@ blocks together to build programs.  All code is free and open source.
 
 ![](https://developers.google.com/blockly/images/sample.png)
 
-Blockly has an active [developer forum](https://groups.google.com/forum/#!forum/blockly). Please drop by and say hello. Show us your prototypes early; collectively we have a lot of experience and can offer hints which will save you time. We actively monitor the forums and typically respond to questions within 2 working days.
+Blockly has an active [developer forum](https://groups.google.com/forum/#!forum/blockly).  Please drop by and say hello. Show us your prototypes early; collectively we have a lot of experience and can offer hints which will save you time. We actively monitor the forums and typically respond to questions within 2 working days.
 
 Help us focus our development efforts by telling us [what you are doing with
-Blockly](https://developers.google.com/blockly/registration). The questionnaire only takes
+Blockly](https://developers.google.com/blockly/registration).  The questionnaire only takes
 a few minutes and will help us better support the Blockly community.
 
 Cross-browser Testing Platform and Open Source <3 Provided by [Sauce Labs](https://saucelabs.com)
@@ -20,9 +20,12 @@ Want to contribute? Great! First, read [our guidelines for contributors](https:/
 
 ## Releases
 
-We release by pushing the latest code to the master branch, followed by updating our [docs](developers.google.com/blockly) and [demo pages](https://blockly-demo.appspot.com). We typically release a new version of Blockly once a quarter (every 3 months). If there are breaking bugs, such as a crash when performing a standard action or a rendering issue that makes Blockly unusable, we will cherry-pick fixes to master between releases to fix them. The [releases page](https://github.com/google/blockly/releases) has a list of all releases.
+We release by pushing the latest code to the master branch, followed by updating our [docs](https://developers.google.com/blockly) and [demo pages](https://blockly-demo.appspot.com). We typically release a new version of Blockly once a quarter (every 3 months). If there are breaking bugs, such as a crash when performing a standard action or a rendering issue that makes Blockly unusable, we will cherry-pick fixes to master between releases to fix them. The [releases page](https://github.com/google/blockly/releases) has a list of all releases.
 
-Releases are tagged by the release date (YYYYMMDD) with a leading '1.' and a trailing '.0' in case we ever need a major or minor version (such as [1.20190419.0](https://github.com/google/blockly/tree/1.20190419.0)). If you're using npm, a specific release can be installed by using its tag: `npm install git://github.com/google/blockly.git#1.20181219.0`
+Releases are tagged by the release date (YYYYMMDD) with a leading '2.' and a trailing '.0' in case we ever need a major or minor version (such as [2.20190722.1](https://github.com/google/blockly/tree/2.20190722.1)). If you're using npm, you can install the ``blockly`` package on npm: 
+```bash
+npm install blockly
+```
 
 ### New APIs
 
@@ -42,7 +45,7 @@ There are two main branches for Blockly.
 
 ## Issues and Milestones
 
-We typically triage all bugs within 2 working days, which includes adding any appropriate labels and assigning it to a milestone. Please keep in mind, we are a small team so even feature reqeusts that everyone agrees on may not be prioritized.
+We typically triage all bugs within 2 working days, which includes adding any appropriate labels and assigning it to a milestone. Please keep in mind, we are a small team so even feature requests that everyone agrees on may not be prioritized.
 
 ### Milestones
 

appengine/storage.js

@@ -1,9 +1,6 @@
 /**
  * @license
- * Visual Blocks Editor
- *
- * Copyright 2012 Google Inc.
- * https://developers.google.com/blockly/
+ * Copyright 2012 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

appengine/storage.py

@@ -1,7 +1,6 @@
 """Blockly Demo: Storage
 
-Copyright 2012 Google Inc.
-https://developers.google.com/blockly/
+Copyright 2012 Google LLC
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.