Remove multi-line comments to avoid escaping #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Oct 14, 2019
rachel-fenichel
requested changes
Oct 14, 2019
Fixes google#3230 by removing multi-line comments for procedures.
RoboErikG
force-pushed
the
roboerikg-comment-escapes
branch
from
2c69e42
to
f29e2e3
Compare
|
Should be fixed. Waiting on travis |
|
Travis timed out on one of the mocha tests. Restarted the job. |
|
We have mocha timeouts as an issue: #2846 If they're happening too, the short-term fix is to increase the timeout. They're taking longer because we've got a lot more tests than we used to, and that makes sense. In parallel, @alschmiedt was looking into ways to run more tests in parallel, so that travis doesn't take as long on every PR. |
rachel-fenichel
approved these changes
Oct 14, 2019
RoboErikG
added a commit
to RoboErikG/blockly
that referenced
this pull request
Oct 14, 2019
Fixes google#3230 by removing multi-line comments for procedures.
3 tasks
RoboErikG
added a commit
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3230 by removing multi-line comments for procedures.
Should be cherry-picked
The basics
The details
Resolves
Proposed Changes
Reason for Changes
Test Coverage
Tested on:
Documentation
Additional Information
This change is