Viewport events #4395
Merged
Viewport events #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 21, 2020 10:48
moniika
force-pushed
the
viewport-events
branch
from
43675d0
to
636de2b
Compare
added 2 commits
October 23, 2020 17:30
alschmiedt
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
this lgtm! I just have a few things I am curious about:
- Is there a use case in mind for this event?
- Depending on the use case, would it be helpful to have the width and size of the view port for this event?
- Do we nee the blockly_compressed file? I know we need blockly_uncompressed since you added a file, but not sure about blockly_compressed.
I'm going to leave for now, but may add viewport size information in a follow up. |
moniika
pushed a commit
that referenced
this pull request
Nov 4, 2020
* Ui events base (#4370) * Add constants for new ui event types * Add property to indicate an event as UI event * Click events (#4372) * Creating new ui base class. * Refactor theme event (#4391) * Add themeName property to theme event * Refactor marker move events. (#4389) * Refactor trashcan open event (#4392) * Refactor selected event (#4387) * Refactor toolbox item change event (#4394) * Refactor bubble open events (#4390) * Refactor block drag event (#4388) * Viewport events (#4395) * Fix event filtering for ui events (#4401) * Move events to new directory and rename Ui events base (#4400) * Move events to new directory and rename Ui events base * Add missing fromJson implementation for click event (#4410) * Adding serialization tests for events * Zoom controls event (#4407) * Refactor zoom event * Rename IS_UI_EVENT to isUiEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #4203
Part of #1052
Proposed Changes
Creates dedicated class (
Blockly.Events.ViewportChange) for viewport change events.Reason for Changes
See issue, but generally motivated by:
Test Coverage
Tested by logging events on playground and observing that expected events were logged and running mocha tests.
Tested on: