Move events to new directory and rename Ui events base #4400
Conversation
core/events/ui_events.js
Outdated
| goog.require('Blockly.registry'); | ||
| goog.require('Blockly.utils.object'); | ||
|
|
||
| /** | ||
| * Class for a UI event. |
There was a problem hiding this comment.
assuming i understand these changes correctly, i might add 'base class for a ui event, use the more specific event type in core/events if possible' or some other text explaining. because if i understand correctly this isn't meant to be used directly (?)
and same below for the plain Ui event, maybe add that it's there for compatibility but you should use the new event classes
There was a problem hiding this comment.
I've update Jsdoc for both and added @deprecated annotation to Events.Ui
There was a problem hiding this comment.
Adding @deprecated is an issue for travis until I also fix zoom event that is still using old class. Since I want to handle that in a seperate PR, I'm just going to update the jsdoc here.
* Ui events base (#4370) * Add constants for new ui event types * Add property to indicate an event as UI event * Click events (#4372) * Creating new ui base class. * Refactor theme event (#4391) * Add themeName property to theme event * Refactor marker move events. (#4389) * Refactor trashcan open event (#4392) * Refactor selected event (#4387) * Refactor toolbox item change event (#4394) * Refactor bubble open events (#4390) * Refactor block drag event (#4388) * Viewport events (#4395) * Fix event filtering for ui events (#4401) * Move events to new directory and rename Ui events base (#4400) * Move events to new directory and rename Ui events base * Add missing fromJson implementation for click event (#4410) * Adding serialization tests for events * Zoom controls event (#4407) * Refactor zoom event * Rename IS_UI_EVENT to isUiEvent
The basics
The details
Resolves
Part of #4203
Proposed Changes
UiBaseUiUiclass into same file asUiBaseCreates dedicated class (
Blockly.Events.ViewportChange) for viewport change events.Reason for Changes
Test Coverage
Tested by logging events on playground and observing that expected events were logged and running mocha tests.
Tested on: