Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds shortcut items #4408

Merged
merged 3 commits into from Oct 29, 2020
Merged

Adds shortcut items #4408

merged 3 commits into from Oct 29, 2020

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Adds shortcut items.

Proposed Changes

Refactor Blockly.onKeyDown to use the shortcuts registry.
Registers the default shortcut options that used to be in onKeyDown.

Reason for Changes

Test Coverage

Tested on:

Documentation

Additional Information

This is a partial PR. For the full change see #4397.

@rachel-fenichel
Copy link
Collaborator

This looks solid overall, but I'll ping you tomorrow to walk me through some of the details.

@alschmiedt alschmiedt merged commit 98b7dd5 into google:keyboard_shortcuts Oct 29, 2020
alschmiedt added a commit that referenced this pull request Nov 2, 2020
@alschmiedt
Keyboard shortcuts (#4421)
f1498e7 
* Adds shortcut registry and removes action and key map (#4398)

* Adds Shortcut tests and refactored navigation tests (#4412)

* Adds shortcut items (#4408)

* Add shortcuts for navigation (#4409)

* Add final keyboard shortcut cleanup (#4413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees

@rachel-fenichel rachel-fenichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alschmiedt @rachel-fenichel