Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut tests and refactored navigation tests #4412

Merged
merged 3 commits into from Oct 27, 2020
Merged

Shortcut tests and refactored navigation tests #4412

merged 3 commits into from Oct 27, 2020

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

Adds tests for keyboard shortcuts.
Refactors tests for navigation.
Removes key map tests.

Reason for Changes

Test Coverage

Tested on:

Documentation

Additional Information

This is a partial PR and will therefore fail on Travis. For the full PR see #4397.

moniika
moniika approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@moniika moniika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My main concern is just about how some of the tests seem to trigger console logs. As part of #4194, been trying to clean them up.

tests/mocha/shortcut_registry_test.js Show resolved Hide resolved
tests/mocha/shortcut_registry_test.js Outdated Show resolved Hide resolved
@alschmiedt alschmiedt merged commit 87ca944 into google:keyboard_shortcuts Oct 27, 2020
alschmiedt added a commit that referenced this pull request Nov 2, 2020
@alschmiedt
Keyboard shortcuts (#4421)
f1498e7 
* Adds shortcut registry and removes action and key map (#4398)

* Adds Shortcut tests and refactored navigation tests (#4412)

* Adds shortcut items (#4408)

* Add shortcuts for navigation (#4409)

* Add final keyboard shortcut cleanup (#4413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moniika moniika moniika approved these changes

Assignees

@moniika moniika

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alschmiedt @moniika