chore: add tests for procedure serialization #6574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: chore
BeksOmega
commented
Oct 20, 2022
| suite.skip('Procedures', function() { | ||
| setup(function() { | ||
| this.procedureMap = this.workspace.getProcedureMap(); | ||
| }); |
BeksOmega
force-pushed
the
test/procedure-serialization
branch
from
1d1d08e
to
d942f08
Compare
github-actions
bot
added
PR: chore
BeksOmega
force-pushed
the
test/procedure-serialization
branch
2 times, most recently
from
fda2060
to
751a1aa
Compare
github-actions
bot
added
PR: chore
NeilFraser
approved these changes
Oct 24, 2022
BeksOmega
force-pushed
the
test/procedure-serialization
branch
from
751a1aa
to
66e998a
Compare
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #6521
Proposed Changes
Adds tests for procedure serialization.
Reason for Changes
Tests are good!
Test Coverage
This is tests silly!
Documentation
N/A
Additional Information
I also need to add tests for deserialization - but all of our deserialization tests right now are round-trip tests, and I'm not sure that that's going to hit everything I want it to hit. So I'm going to investigate that separately.
Dependent on #6575