fix: refactors concrete implementations of the procedure data models #6575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
BeksOmega
force-pushed
the
fix/refactor-concretes
branch
from
9377b0c
to
f94f8ea
Compare
|
Ok @maribethb I think this is ready for a look! |
maribethb
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
No tracking issue for this, just what we discussed in internal chat / vc.
Proposed Changes
Behavior Before Change
Behavior After Change
Reason for Changes
Three separate things:
Mapmethods)Test Coverage
Relevant tests already existed.
Documentation
N/A
Additional Information
Dependent on #6570