Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOBMCN2-24 Added checks to ensure as much as possible that the main playbook wil… #54

Closed
wants to merge 3 commits into from

Conversation

muresan
Copy link
Contributor

@muresan muresan commented Oct 20, 2020

…l not fail

@muresan muresan changed the title Added checks to ensure as much as possible that the main playbook wil… GOBMCN2-24 Added checks to ensure as much as possible that the main playbook wil… Oct 20, 2020
@muresan
Copy link
Contributor Author

muresan commented Oct 20, 2020

The PR has the same changes as #6

Copy link
Member

@mfielding mfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like the refactoring here.

roles/check-instance/defaults/main.yml Outdated Show resolved Hide resolved

required_mem_mb: 15000

supported_distributions_19c:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned this list gets very complicated quickly, and challenging to keep up to date, as more versions and OSes are added. For example, SuSE Linux, el8 kernels, Oracle 12cR1, 11gR2, 20c etc? Might this be one place we could fall back on Oracle's own install prerequisite checks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-install check, for obvious reasons we cannot include here the Oracle checks and the initial request was to eliminate as much as possible an install-time fail, this is the OS check part. The OS/Kernel combination is compared to the list and anything newer is accepted so the list needs to be updated only once, anything newer will be automatically included.
I could not find anything for the other distributions so we can have a baseline and start from there, but I wanted something official

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here. My preference would be to avoid duplicating too much of the Oracle checks, but rather check for what we need to get the toolkit itself to run. How about removing the kernel versions entirely, and just focusing on OS major releases, ideally without making distinctions between Oracle versions. Perhaps as simpe as OL7 or RHEL7? (And I hope OL8/RHEL8 too?)

check-instance.yml Outdated Show resolved Hide resolved
@muresan muresan closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants