Fix Python 3 compatibility bug

[jcnars]

(Described also with additional snippets in (internal) https://b.corp.google.com/issues/202240337#comment16 through comment#21)

Got into a situation where for the same given asm_disk.json, data_mount.json config files input to the toolkit, targetted to be run on the very same BMX host, we had a successful vs failure case:

• successful: when run from existing control-node / GCP VM, ansible version 2.9.25, Python version 2.7.5
• failure: when run from a GKE pod, ansible version 2.9.25, Python version 3.8.6

The failure message was:

TASK [ora-host : (udev) Add ASM mpath disk rules on BM (udev rules file)] ******
fatal: [bmshost.orcl]: FAILED! => {"msg": "Unexpected templating type error occurred on (ACTION==\"add|change\",
 ENV{DM_UUID}==\"{{ item }}\", SYMLINK+=\"{{ path_udev }}/{{ uuid_result[item] | json_query ('[*].name') | list | 
join(', ') }}\", GROUP=\"{{ grid_group }}\", OWNER=\"{{ grid_user }}\", MODE=\"0660\"): 'NoneType' object is not 
iterable"}

PLAY RECAP *********************************************************************
bmshost.orcl         : ok=64   changed=4    unreachable=0    failed=1    skipped=24   rescued=0    ignored=0 

• After extensive debugging, it was found that using the key was the key :)
  • This is the reason: Errors with configuration.yml and Python 3 jdauphant/ansible-role-nginx#150
  • Gist is: Python3 breaks with_items: <dict>.keys() and needs to be replaced with with_dict: <dict>
• This proposed fix is tested from both Python2 (where it didn't break prior to this proposed change) and Python3 (where this issue was exposed and the proposed solutions works) clients successfully.
• I have checked that there's no other instance of with_items: <dict>.keys() in our toolkit code that can lead to this.

[mfielding]

Nice catch!

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcnars, mfielding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcnars,mfielding]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment