Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper build system #162

Closed
fxfactorial opened this issue Sep 23, 2015 · 8 comments
Closed

Proper build system #162

fxfactorial opened this issue Sep 23, 2015 · 8 comments

Comments

@fxfactorial
Copy link

Can you guys use a proper build system, cmake or even a plain makefile?

At least so that we can get a single .so/.dylib and be able to easily link against it via -lbrotli or something.

@bagder
Copy link

bagder commented Sep 24, 2015

I've started a little attempt at build scripts and setup to build a library (.so and .a with libtool) from the brotli source code here: https://github.com/bagder/libbrotli

Builds a decoder lib right now.

@fxfactorial
Copy link
Author

@bagder Nice thanks, is it feasible to eventually have just one library instead of separate ones for encoder, decoder?

@bagder
Copy link

bagder commented Sep 25, 2015

Oh certainly. This is just starting so I'm interested in feedback and improvements. I simply started with the decoder parts because that is where my primary interest lies.

@aa88088aa
Copy link

你傳什麼?我要密碼
2015/9/30 下午9:46於 "nuch-lek" notifications@github.com寫道:

VID_20150927_014307.mp4
<
https://drive.google.com/file/d/1dAVtiGs0KV8nUr6lSCj80bWw2MT2-WxksA/view?usp=drivesdk

VID_20150927_014305.mp4
<
https://drive.google.com/file/d/1ntKHY9Yhql6vD0GZ_eIvXyQbG_Ayueh4Sg/view?usp=drivesdk

ส่งจาก Gmail มือถือ


Reply to this email directly or view it on GitHub
#162 (comment).

@CoolOppo
Copy link

@aa88088aa I think you may have accidentally replied to the wrong issue or something.

@aa88088aa
Copy link

I lost my password , demanding to know the password ? Know what I mean?
2015/10/1 上午6:43於 "CoolOppo" notifications@github.com寫道:

@aa88088aa https://github.com/aa88088aa I think you may have
accidentally replied to the wrong issue or something.


Reply to this email directly or view it on GitHub
#162 (comment).

@CoolOppo
Copy link

CoolOppo commented Oct 1, 2015

i really have no idea what you mean

On Wed, Sep 30, 2015 at 7:32 PM aa88088aa notifications@github.com wrote:

I lost my password , demanding to know the password ? Know what I mean?
2015/10/1 上午6:43於 "CoolOppo" notifications@github.com寫道:

@aa88088aa https://github.com/aa88088aa I think you may have
accidentally replied to the wrong issue or something.


Reply to this email directly or view it on GitHub
#162 (comment).


Reply to this email directly or view it on GitHub
#162 (comment).

@GuillaumeRossolini
Copy link

Actually, there seems to be makefiles inside each folder (dec, enc, tools). To build everything, cd to "tools" then "make".
Or am I mistaken?
Doesn't have the "install" procedure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@bagder @CoolOppo @fxfactorial @GuillaumeRossolini @aa88088aa and others