Handle SMP_Security_Request #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
approved these changes
Sep 19, 2023
bumble/pandora/security.py
Outdated
| @@ -294,23 +294,37 @@ async def Secure( | |||
| try: | |||
| self.log.debug('Pair...') | |||
|
|
|||
| wait_for_security = asyncio.get_running_loop().create_future() | |||
|
|
|||
| def on_pairing(*_: Any) -> None: | |||
There was a problem hiding this comment.
suggest: you could use the decorator syntax here:
@connection.on("pairing")
def on_pairing(*_: Any) -> None:
...
There was a problem hiding this comment.
Random chat: If there could be a once-but-destroy-on-leave(just like other local variables' lifecycle) that will be useful
There was a problem hiding this comment.
See PR #292 for a proposal of how this could be done.
barbibulle
reviewed
Sep 19, 2023
uael
approved these changes
Sep 19, 2023
|
@barbibulle could you please tag a new release after this is merged ? |
|
Rebased on #293 |
|
Can you rebase on top of main ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It's different from other delegation methods, but this mode looks more "Bumble"(considering the EE).
Alternative: If we still prefer PairingDelegate mode, we may add a
get_security_action(peer_address, auth_req)method in PairingDelegate, which returns one of the following action, and perform the corresponding action: