Add Pyee EventWatcher #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
force-pushed
the
event_context
branch
from
1f3ea47
to
32147b8
Compare
barbibulle
reviewed
Sep 20, 2023
zxzxwu
force-pushed
the
event_context
branch
from
32147b8
to
5ca6f79
Compare
|
Looks there are some type error, checking |
|
Probably because mypy cannot identify the type from context, so it is required to add overloading to fulfill it :( |
uael
approved these changes
Sep 20, 2023
barbibulle
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #292 (comment)