Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config knob to disable collecting root cgroup stats #2259

Open
sashankreddya opened this issue Jun 25, 2019 · 0 comments
Open

Config knob to disable collecting root cgroup stats #2259

sashankreddya opened this issue Jun 25, 2019 · 0 comments

Comments

@sashankreddya
Copy link
Collaborator

sashankreddya commented Jun 25, 2019

We have seen a performance issue while reading memory.stat file for “rootCgroup”. It might be partially due to a kernel issue . The time taken to read "/sys/fs/cgroup/memory/memory.stat" is of the order of "3~8s". This also correlates to one of the earlier discussion thread as in here seen by others of the openSource community. Once we disable collecting root cgroup stats with some thing like below, the CPU spike reduced from close to 100% to 2%.

func (self *rawContainerHandler) GetStats() (*info.ContainerStats, error) { if disable_rootCgroup_stats && isRootCgroup(self.name) { return nil, nil }

It would be nice if we can have a config knob to not collect root cgroup stats if set.

dashpole added a commit that referenced this issue Aug 11, 2019
Provide a config knob to disable collecting root Cgroup stats #2259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant