Podman support.

[Creatone]

Fixes #2424

Signed-off-by: Paweł Szulik pawel.szulik@intel.com

[strideynet]

Hey ! This PR is looking good and has some functionality we've been needing in a recent project. How's this going ? Still being worked on ?

[Creatone]

@strideynet I'm on holiday now, when I get back I'll try to end it :D

[rhatdan]

Any udpate on this PR?

[Creatone]

Any udpate on this PR?

Still a work in progress, so many things simultaneously to do. I think that half work is done. Soon I will end this PR :)

[Crapshit]

@dims @bobbypage @iwankgb @mrunalp could you please move this forward? Thank you in advance

[dims]

@Crapshit as i am not a google employee, i consider myself as a guest here. I do not want to merge a feature without explicit ok from google folks.

[Crapshit]

Ok, understand @dims.
I thought you would merge it, because you are member of the core team

[dims]

@Crapshit thanks! (my mandate has been to make sure k8s usage of cadvisor is covered to be a bit more specific)

[Crapshit]

@Creatone do you think it could help if we assign this PR to @bobbypage ?

[Creatone]

@Crapshit I don't think so.

[xeizmendi]

@dims @bobbypage @iwankgb @mrunalp in order to add podman support to cadvisor is creating a fork the only solution?

To me it looks like this PR is being ignored on purpose.

[iwankgb]

@xeizmendi I will speak for myself: I am an volunteer working on cAdvisor in my free time. At the moment I'm probably half done with review of this PR and I find your comments offensive: this is free software, what stops you from helping out and reviewing this code?

[xeizmendi]

@iwankgb I thought only one of the project maintainers has the right to review/approved the code. If anybody can do so, then I'm sorry. Can anybody review the PR? Is there any documentation on what are the code review requirements for this project?

The PR has been sitting unreviewed for over six months and there have been no comments from core maintainers, hence my frustration.

[iwankgb]

@xeizmendi lack of comments usually boils down to lack of time. This is reality of FOSS.
I will finish reviewing this PR as soon as possible and I hope that second round will be just a formality :) keep in mind that further progress will depend on @Creatone availability and his current priorities (in his free time, AFAIK).

[iwankgb]

Regarding reviewing: everyone can review, maintainers can approve and merge.

[iwankgb]

Just two comments, @Creatone

[xeizmendi]

Thank you very much @Creatone, all the people who reviewed the code and to @iwankgb who unblocked this PR!

[pixelsoccupied]

Hello! Really appreciate the podman support and I was able to clone and build from the main branch without any issue.

Was wondering if there's any release schedule I can keep an eye on? I'm guessing the next release will have whatever is currently on the master branch?

p.s not sure if it's being tracked already/looking contribution but the current implementation (from 2-ish weeks ago) is missing equivalent -docker_only or -docker_tls

[mailinglists35]

@Creatone I run each rootless podman container in their own Linux user shell. Is there any chance you can support this scenario?

I see cadvisor container already maps /var/run/ , and on host the users containers are in /run/user/ (/var/run is link to /run)

[mailinglists35]

@Creatone it would need to walk through each readable /var/run/user/*/podman/podman.sock files, so instead of a single endpointFlag in

cadvisor/container/podman/factory.go

Line 40 in 04006e5

endpointFlag = flag.String("podman", "unix:///var/run/podman/podman.sock", "podman endpoint")

I guess you would need to find a way to process multiple file socket paths instead of one