Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export-memory-kernal-usage #3306

Merged
merged 1 commit into from Jul 4, 2023
Merged

export-memory-kernal-usage #3306

merged 1 commit into from Jul 4, 2023

Conversation

0del
Copy link
Contributor

@0del 0del commented May 9, 2023 •
edited by iwankgb

Pick up the PR: #2302
Fixes: #2138

Through prometheus testing the following relationship seems to be present:
container_memory_usage_bytes == container_memory_rss + container_memory_cache + container_memory_kernel

please review @dashpole
Thanks

@google-cla
Copy link

google-cla bot commented May 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @9bany. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0del 0del changed the title ft/export-memory-kernal-usage export-memory-kernal-usage May 9, 2023
@0del
Copy link
Contributor Author

0del commented May 9, 2023

/ok-to-test

@k8s-ci-robot
Copy link
Collaborator

@9bany: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@0del 0del mentioned this pull request May 11, 2023
Closed
iwankgb
iwankgb reviewed Jun 27, 2023
View reviewed changes
info/v1/container.go Outdated Show resolved Hide resolved
@iwankgb
Copy link
Collaborator

iwankgb commented Jun 27, 2023

Merge master to the branch, please.

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 29, 2023

One final request: could you squash the commits into single one, please? LGTM besides this :)

@0del 0del force-pushed the ft/export-memory-kernal-usage branch 2 times, most recently from 8cdffd7 to c26e3f6 Compare June 30, 2023 03:53
@0del
Copy link
Contributor Author

0del commented Jun 30, 2023

@iwankgb just done

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 30, 2023

@9bany you must sign Google CLA, otherwise I won't be able to merge the PR.

@0del 0del force-pushed the ft/export-memory-kernal-usage branch from c26e3f6 to 65afedd Compare July 1, 2023 03:00
@0del
Copy link
Contributor Author

0del commented Jul 1, 2023

Sorry for the inconvenience, I had some problems with my Git config. I think everything is okay now. @iwankgb

@iwankgb
Copy link
Collaborator

iwankgb commented Jul 2, 2023

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Jul 2, 2023

@9bany fix liter error, please.

@0del 0del force-pushed the ft/export-memory-kernal-usage branch from 65afedd to a8b1fcf Compare July 3, 2023 02:10
@0del
Copy link
Contributor Author

0del commented Jul 3, 2023

/retest

@0del 0del force-pushed the ft/export-memory-kernal-usage branch from a8b1fcf to cd663bd Compare July 4, 2023 04:40
@0del
Copy link
Contributor Author

0del commented Jul 4, 2023

@iwankgb just done

@iwankgb iwankgb merged commit 0f004a2 into google:master Jul 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwankgb iwankgb iwankgb approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export container kernel memory usage to Prometheus
3 participants
@0del @k8s-ci-robot @iwankgb