Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting container_memory_kernel from memory.kmem.usage_in_bytes #2302

Closed

Conversation

thomasf1234
Copy link

In response to #2138

Through prometheus testing the following relationship seems to be present:

container_memory_usage_bytes == container_memory_rss + container_memory_cache + container_memory_kernel

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Collaborator

Hi @thomasf1234. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Collaborator

/ok-to-test

@nobody4t
Copy link

nobody4t commented Mar 2, 2020

Is this true? What about the result? Seems not completed.

@nobody4t
Copy link

Hi what is the progress of this? What about the result?

@dashpole
Copy link
Collaborator

Looks like the CLA was never signed for this, so i'm not able to accept it. This seems like a reasonable change though, so if anyone wants to pick this up, I think it should be acceptable.

@dashpole dashpole closed this Sep 11, 2020
@danishprakash
Copy link

@dashpole I'll take a shot at this.

@dashpole
Copy link
Collaborator

dashpole commented Sep 23, 2021

@danishprakash I am no longer the maintainer of cAdvisor, so you'll need to work with @bobbypage

@9bany 9bany mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants