-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting container_memory_kernel from memory.kmem.usage_in_bytes #2302
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @thomasf1234. Thanks for your PR. I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Is this true? What about the result? Seems not completed. |
Hi what is the progress of this? What about the result? |
Looks like the CLA was never signed for this, so i'm not able to accept it. This seems like a reasonable change though, so if anyone wants to pick this up, I think it should be acceptable. |
@dashpole I'll take a shot at this. |
@danishprakash I am no longer the maintainer of cAdvisor, so you'll need to work with @bobbypage |
In response to #2138
Through prometheus testing the following relationship seems to be present:
container_memory_usage_bytes
==container_memory_rss
+container_memory_cache
+container_memory_kernel