Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add misc controller metrics #3420

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add misc controller metrics #3420

wants to merge 6 commits into from

Conversation

mythi
Copy link

@mythi mythi commented Oct 26, 2023

Keeping it draft still since it pulls github.com/opencontainers/runc@main.

@google-cla
Copy link

google-cla bot commented Oct 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @mythi. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, except for the changes in runc usage, but I'll let others comment on that.

container/libcontainer/helpers_test.go Outdated Show resolved Hide resolved
docs/storage/prometheus.md Outdated Show resolved Hide resolved
@mythi
Copy link
Author

mythi commented Nov 7, 2023

moving away from draft to get more feedback.

@mythi mythi marked this pull request as ready for review November 7, 2023 11:49
@mythi
Copy link
Author

mythi commented Nov 27, 2023

moving away from draft to get more feedback.

any early feedback from the maintainers?

@iwankgb
Copy link
Collaborator

iwankgb commented Dec 25, 2023

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Dec 25, 2023

Can you undo changes to go.mods, please?

@mythi
Copy link
Author

mythi commented Jan 8, 2024

Can you undo changes to go.mods, please?

The PR won't build without those changes. I can rebase to resolve conflicts to get the e2e tests going but I believe we can wait with this PR until runc 1.2.0 comes out.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Modeled after Hugetlb support (except that this skips
DeprecatedContainerStats) and added to sources after it.
Modeled after Hugetlb support and added to sources after it.
Modeled after Hugetlb support and added to sources after it.
@k8s-ci-robot
Copy link
Collaborator

@mythi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cadvisor-e2e fb056e5 link true /test pull-cadvisor-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants