Use cargo-metadata by default (instead of cargo internals)
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the implementation to use cargo metadata instead of compiled-in cargo internals.
It adds some backup flags in case this breaks some folks.
--
--cargo-bin-pathLets you set the path to the cargo binary used for running cargo-metadata--
--deprecated-use-cargo-internalsForces usage of the cargo internals implementationI'm going to up the minor version for this change.
cc: #132
This doesn't fix that bug since it doesn't remove the cargo dep, but it opens the door to fixing it after this has been released for a bit. If folks don't have issues, we can drop the "internals" impl, and remove lingering usages of the cargo dependency