Added data folder and person class #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apluscs
requested changes
Jun 29, 2020
| * The email is used as the key to the user table. | ||
| */ | ||
| public class Person { | ||
| private string email, name, company, job, linkedin; |
There was a problem hiding this comment.
Pretty sure we need these to be defined on different lines. Can @acmcarther or @jalexanderqed confirm (or deny) this?
apluscs
approved these changes
Jun 30, 2020
apluscs
requested changes
Jun 30, 2020
apluscs
requested changes
Jun 30, 2020
apluscs
approved these changes
Jun 30, 2020
apluscs
requested changes
Jun 30, 2020
|
@apluscs the key() method returns the email, should I just change the name of the method? |
|
Nit: PR title is too long. Use the description for details. Example: google/cargo-raze#134 |
acmcarther
approved these changes
Jun 30, 2020
GrantComm
changed the title
Yes that'd be good! |
apluscs
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is made to replace what was previously approved and merged into #33.