Complain to stderr about unused raze settings.

[mfarrugi]

Found myself upgrading crates and not (quickly) noticing that overrides were no longer being applied.

Not sure if this should be a harder error, lmk if you'd like it done differently. The output is kind of noisy right now as well, which may make this hard to notice if you don't know to look for it.

[acmcarther]

This looks good to me. At some point I planned to print something like
Found X @ t1, which didn't have a matching dependency, did you mean X @ [t2,t3,t4]
and I think there is code like that floating around somewhere in some other repo..

If you want to change this to hint at the available other versions, that would be nice, else we can do it some time later. LMK either way.

[mfarrugi]

@acmcarther I added the version hint

[acmcarther]

LGTM, thanks for quick fix!

[mfarrugi]

@acmcarther I want to promote this to a hard error (since I ran into it again :|), any objection?

The other option would be to replace the Generated $CRATE successfully with Generated $count crates successfully, but I imagine most people are going to ignore non-error output that takes more than 1 screen.

[acmcarther]

Changing the warning to an error SGTM

Code was restructured recently, here is where the warning happens now:

cargo-raze/impl/src/planning.rs

Lines 788 to 828 in afe4255

	pub fn warn_unused_settings(
	all_crate_settings: &HashMap<String, CrateSettingsPerVersion>,
	all_packages: &Vec<Package>,
	) {
	let mut known_versions_per_crate = HashMap::new();
	for &Package {
	ref name,
	ref version,
	..
	} in all_packages.iter()
	{
	known_versions_per_crate
	.entry(name.clone())
	.or_insert(HashSet::new())
	.insert(version.clone());
	}
	for (name, settings_per_version) in all_crate_settings.iter() {
	if !known_versions_per_crate.contains_key(name) {
	eprintln!(
	"Found unused raze settings for all of {}-{:?}",
	name,
	settings_per_version.keys()
	);
	// No version introspection needed -- no known version of this crate
	continue;
	}
	// UNWRAP: Guarded above
	let all_known_versions = known_versions_per_crate.get(name).unwrap();
	for version in settings_per_version.keys() {
	if !all_known_versions.contains(version) {
	eprintln!(
	"Found unused raze settings for {}-{}, but {:?} were known",
	name, version, all_known_versions
	)
	}
	}
	}
	}