Set CARGO and RUSTC environment variables to make Bazel tests more hermetic
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfreese This one solves for one of issues @acmcarther ran into in his quest for setting up BazelCI. This contains the most impactful fixes of getting that working. |
|
This looks like it deals with three separate issues. Can you break those out into individual PRs? |
UebelAndre
changed the title
CARGO and RUSTC environment variables to make tests more hermetic
UebelAndre
changed the title
CARGO and RUSTC environment variables to make tests more hermeticCARGO and RUSTC environment variables to make Bazel tests more hermetic
dfreese
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the changes introduced in bazelbuild/rules_rust#588, cargo raze can now correctly specify the
cargoandrustcbinaries to use during tests and no longer require the host to have either installed. For users running the target, however, the binaries are still required to be installed but this should be a simple change that can be made in the future