Prefixed 3rd party dependencies with cargo_raze__ to match existing…
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… patterns and prevent conflicts in other repos
dfreese
approved these changes
Feb 20, 2021
| @@ -10,7 +10,7 @@ filegroup( | |||
| configure_make( | |||
| name = "iconv", | |||
| configure_env_vars = select({ | |||
| "@platforms//os:macos": {"AR": ""}, | |||
| "@rules_rust//rust/platform:darwin": {"AR": ""}, | |||
There was a problem hiding this comment.
Is this change auto-generated, or manual? If manual, why go with rules_rust's version, rather than just platforms?
There was a problem hiding this comment.
Use of @platform here isn't supported in versions before... 3.6 if I recall correctly. Using the rust config settings guarantees the same level of compatibility the rules offers.
There was a problem hiding this comment.
Specifically because @platforms defines constraint_values and not config_settings.
There was a problem hiding this comment.
Looks like 3.7
select() directly supports constraint_value with no need for an intermediate config_setting.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3rd party dependencies had their names updated to prevent any kinds of conflicts with other repository names. This should further improve the reproducibility of cargo-raze builds and tests.