Consolidate duplicated targeted dependencies. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayrer
requested review from
dfreese,
UebelAndre,
illicitonion and
acmcarther
as code owners
|
Hmm, I guess this will fix the problem, but it will create more select blocks than necessary. It will end up looking pretty similar to the bottom of features.rs, I'll see if it's worth making it generic. |
sayrer
force-pushed
the
consolidate_targeted_deps
branch
from
7328caf
to
455761f
Compare
sayrer
commented
Jun 26, 2022
|
Most of the changes after bootstrapping are just innocuous alphabetization. But there are a few problems still there: third_party/cargo/remote/BUILD.async-std-1.9.0.bazel (wasm32-wasi is newly missing) After those are resolved, it will make sense to eliminate platform select blocks with no members (this can happen if common dependencies are hoisted out of selects in an effort to avoid repetition) |
|
This latest revision fixed all of the bootstrapping problems I found above. |
dmitrii-ubskii
added a commit
to typedb/dependencies
that referenced
this pull request
Nov 23, 2022
## What is the goal of this PR? We add the cucumber testing framework crate to our pinned rust dependencies. ## What are the changes implemented in this PR? While making this change, we encountered an issue in bazel (bazelbuild/bazel#13785) that made it throw an error because, in essence, libc was included in two out of three conditions, which was regarded as a dependency duplication. Cargo-raze is aware of this issue (google/cargo-raze#451) and has their own workaround in the works (google/cargo-raze#512) which is not being reviewed or merged due to reviewer bandwidth issues. As our own workaround, we separate the inclusion of libc into its own condition, overriding raze and pacifying bazel. This change is stored separately from the razed crates and reapplied when `library/crates/update.sh` is run.
jamesreprise
pushed a commit
to jamesreprise/vaticle-dependencies
that referenced
this pull request
Dec 5, 2022
## What is the goal of this PR? We add the cucumber testing framework crate to our pinned rust dependencies. ## What are the changes implemented in this PR? While making this change, we encountered an issue in bazel (bazelbuild/bazel#13785) that made it throw an error because, in essence, libc was included in two out of three conditions, which was regarded as a dependency duplication. Cargo-raze is aware of this issue (google/cargo-raze#451) and has their own workaround in the works (google/cargo-raze#512) which is not being reviewed or merged due to reviewer bandwidth issues. As our own workaround, we separate the inclusion of libc into its own condition, overriding raze and pacifying bazel. This change is stored separately from the razed crates and reapplied when `library/crates/update.sh` is run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should actually fix #451.