Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add py_proto_library support (rules_python approach) #318

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add py_proto_library support (rules_python approach) #318

wants to merge 1 commit into from

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Oct 6, 2023 •
edited
Loading

Needed to add the support of the new stable CEL to cncf/xds/type/v3/cel.proto. This will bring the new CEL into Envoy and gRPC xDS.

ref cncf/xds#69

@sergiitk
Copy link
Member Author

sergiitk commented Oct 6, 2023

cc @l46kok

@sergiitk sergiitk mentioned this pull request Oct 6, 2023
Closed
@sergiitk sergiitk marked this pull request as draft October 6, 2023 09:33
@l46kok
Copy link
Collaborator

l46kok commented Oct 6, 2023

/gcbrun

@TristonianJones
Copy link
Collaborator

/gcbrun

@sergiitk
Copy link
Member Author

I'm a bit unsure if using rules_python is too early. The majority of the community is using py_proto_library from old-style packages, e.g. @com_google_protobuf//:protobuf.bzl or @com_github_grpc_grpc//bazel:python_rules.bzl. I'll continue looking into this.

@sergiitk sergiitk changed the title Add py_proto_library support Add py_proto_library support (rules_python approach) Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiitk @l46kok @TristonianJones