-
Notifications
You must be signed in to change notification settings - Fork 36
Issue #173 follow-up - Move Extensions text into a separate subsection #244
Conversation
draft-ietf-trans-rfc6962-bis.md
Outdated
} Extension; | ||
~~~~~~~~~~~ | ||
|
||
The `Extension` structure provides a generic extensibility for log entries, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The term 'log entries' here is a bit vague: SCTs and STHs are not log entries. They are artifacts produced by the log. Maybe it'd be better to replace it with 'log artifacts' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't say that SCTs and STHs are log entries. "log entries" is the first of three items in a list; the second item is SCTs, and the third item is STHs.
However, to make it clear, I'll do "s/entries,/artifacts, including/".
draft-ietf-trans-rfc6962-bis.md
Outdated
IANA is asked to establish a registry of SCT extensions, named "CT Extension | ||
Types for SCT", that initially consists of: | ||
IANA is asked to establish a registry of `ExtensionType` values, named "CT | ||
Extension Types", that initially consists of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming the registry to CT log artifact extension types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two small suggestions.
draft-ietf-trans-rfc6962-bis.md
Outdated
IANA is asked to establish a registry of SCT extensions, named "CT Extension | ||
Types for SCT", that initially consists of: | ||
IANA is asked to establish a registry of `ExtensionType` values, named "CT Log | ||
Artifact ExtensionTypes", that initially consists of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "Extension Types" (two words)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ExtensionType" is one word though, and it matches IANA is asked to establish a registry of `VersionedTransType` values, named "CT VersionedTransTypes
.
i.e., We didn't write named "CT VersionedTrans Types"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's: 1) call it "CT Log Artifact Extensions", and 2) rename the "Value" column to "ExtensionType", and 3) rename the "Extension" column to "Status".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest revision LGTM.
Merged at d4fb5ce |
No description provided.