Move auth functions to auth.ts #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including: REDIRECT_URI_OOB oauth2Client getAPICredentials authorizeWithLocalHost authorizeWithoutLocalHost Signed-off-by: campionfellin <campionfellin@gmail.com>
campionfellin
commented
Apr 29, 2018
| const script = google.script({ | ||
| version: 'v1', | ||
| auth: oauth2Client, | ||
| }); | ||
|
|
||
| // Log messages (some logs take required params) | ||
| const LOG = { | ||
| export const LOG = { |
There was a problem hiding this comment.
See note above: this is just temporary
campionfellin
commented
Apr 29, 2018
| const open = require('open'); | ||
| const readline = require('readline'); | ||
| //Just for now, until it moves into /src/commands.ts | ||
| import { LOG } from '../index.js'; |
There was a problem hiding this comment.
See note, this is just temporary until we make /src/commands.ts
Pull Request Test Coverage Report for Build 136
💛 - Coveralls |
|
Thanks for the detailed comments. LGTM. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including:
REDIRECT_URI_OOB
oauth2Client
getAPICredentials
authorizeWithLocalHost
authorizeWithoutLocalHost
Note: I am exporting LOG from
index.tsjust until we move it to/src/commands.tsAlso, though the
tsconfig.jsonfile still has this:It still compiles
/src/auth.tsinto/src/auth.js. Might be worth looking into.Signed-off-by: campionfellin campionfellin@gmail.com
Works on #134
npm run testsucceeds.npm run lintsucceeds.