Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LOG to /src/commands.ts #155

Merged
merged 3 commits into from Apr 30, 2018
Merged

Move LOG to /src/commands.ts #155

merged 3 commits into from Apr 30, 2018

Conversation

campionfellin
Copy link
Collaborator

Addresses comments in #154

Signed-off-by: campionfellin campionfellin@gmail.com

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
Signed-off-by: campionfellin <campionfellin@gmail.com>
@coveralls
Copy link

coveralls commented Apr 30, 2018

Pull Request Test Coverage Report for Build 140

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 260 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 12.29%

Files with Coverage Reduction New Missed Lines %
src/auth.js 10 24.07%
index.js 250 6.49%
Totals Coverage Status
Change from base Build 137: 0.2%
Covered Lines: 133
Relevant Lines: 804

💛 - Coveralls

@grant grant merged commit faed059 into google:master Apr 30, 2018
@grant
Copy link
Contributor

grant commented Apr 30, 2018

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants