Skip to content

Commit

Permalink
Add the Chrome-specific files from https://cs.chromium.org/chromium/s…
Browse files Browse the repository at this point in the history
…rc/third_party/closure_compiler/runner/src/ to the Closure Compiler repo.

They were in the Chromium codebase to make it easier for the Chrome team to develop them, but nowadays they change very infrequently, so having them in the compiler itself will simplify their build scripts because they won't need a custom runner for the compiler; they can just pass the --chrome_pass flag.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=143576616
  • Loading branch information
tbreisacher authored and blickly committed Jan 5, 2017
1 parent 1058c33 commit 28fc969
Show file tree
Hide file tree
Showing 6 changed files with 1,134 additions and 0 deletions.
79 changes: 79 additions & 0 deletions src/com/google/javascript/jscomp/ChromeCodingConvention.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
/*
* Copyright 2014 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;

import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.javascript.jscomp.ClosureCodingConvention.AssertInstanceofSpec;
import com.google.javascript.rhino.Node;
import com.google.javascript.rhino.jstype.FunctionType;
import com.google.javascript.rhino.jstype.ObjectType;
import java.util.Collection;
import java.util.Set;

public class ChromeCodingConvention extends CodingConventions.Proxy {
private final Set<String> indirectlyDeclaredProperties;

public ChromeCodingConvention() {
this(CodingConventions.getDefault());
}

public ChromeCodingConvention(CodingConvention wrapped) {
super(wrapped);
indirectlyDeclaredProperties = new ImmutableSet.Builder<String>()
.add("instance_", "getInstance")
.addAll(wrapped.getIndirectlyDeclaredProperties())
.build();
}

@Override
public String getSingletonGetterClassName(Node callNode) {
Node callArg = callNode.getFirstChild();
if (!callArg.matchesQualifiedName("cr.addSingletonGetter") || callNode.getChildCount() != 2) {
return super.getSingletonGetterClassName(callNode);
}
return callArg.getNext().getQualifiedName();
}

@Override
public void applySingletonGetterOld(FunctionType functionType,
FunctionType getterType, ObjectType objectType) {
super.applySingletonGetterOld(functionType, getterType, objectType);
functionType.defineDeclaredProperty("getInstance", getterType,
functionType.getSource());
functionType.defineDeclaredProperty("instance_", objectType,
functionType.getSource());
}

@Override
public Collection<String> getIndirectlyDeclaredProperties() {
return indirectlyDeclaredProperties;
}

@Override
public Collection<AssertionFunctionSpec> getAssertionFunctions() {
return ImmutableList.of(
new AssertionFunctionSpec("assert"),
new AssertInstanceofSpec("cr.ui.decorate")
);
}

@Override
public boolean isFunctionCallThatAlwaysThrows(Node n) {
return CodingConventions.defaultIsFunctionCallThatAlwaysThrows(
n, "assertNotReached");
}
}

0 comments on commit 28fc969

Please sign in to comment.