A little cleanup for NodeTraversal#traverseChangedFunctions.

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=153834585
google · Apr 25, 2017 · 45f11e3 · 45f11e3
1 parent 8829c16
commit 45f11e3
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/com/google/javascript/jscomp/NodeTraversal.java b/src/com/google/javascript/jscomp/NodeTraversal.java
@@ -541,16 +541,14 @@ public Node getCurrentNode() {
    * Compiler.reportChangeToEnclosingScope(Node n).
    */
   public static void traverseChangedFunctions(
-      AbstractCompiler compiler, FunctionCallback callback) {
-    final AbstractCompiler comp = compiler;
-    final FunctionCallback cb = callback;
-    final Node jsRoot = comp.getJsRoot();
-    NodeTraversal.traverseEs6(comp, jsRoot,
+      final AbstractCompiler compiler, final FunctionCallback callback) {
+    final Node jsRoot = compiler.getJsRoot();
+    NodeTraversal.traverseEs6(compiler, jsRoot,
         new AbstractPreOrderCallback() {
           @Override
-          public final boolean shouldTraverse(NodeTraversal t, Node n, Node p) {
-            if ((n.isScript() || n.isFunction()) && comp.hasScopeChanged(n)) {
-              cb.enterFunction(comp, n);
+          public final boolean shouldTraverse(NodeTraversal t, Node n, Node parent) {
+            if (NodeUtil.isChangeScopeRoot(n) && compiler.hasScopeChanged(n)) {
+              callback.enterFunction(compiler, n);
             }
             return true;
           }