Don't rename names in array patterns. We were mistakenly treating the…

…m as properties. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=169704631
google · Sep 22, 2017 · 62d3242 · 62d3242
1 parent fff2168
commit 62d3242
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/src/com/google/javascript/jscomp/RenameProperties.java b/src/com/google/javascript/jscomp/RenameProperties.java
@@ -365,19 +365,21 @@ public void visit(NodeTraversal t, Node n, Node parent) {
           // Get the object pattern within the destructuring on the lhs
           n = n.getFirstChild();
 
-          // Iterate through all the nodes in the object pattern
-          for (Node key = n.getFirstChild(); key != null; key = key.getNext()) {
-            if (key.isComputedProp()) {
-              // We don't want to rename computed properties
-              continue;
-            } else if (key.isQuotedString()) {
-              // Ensure that we never rename some other property in a way
-              // that could conflict with this quoted key.
-              quotedNames.add(key.getString());
-            } else if (compiler.getCodingConvention().blockRenamingForProperty(key.getString())) {
-              externedNames.add(key.getString());
-            } else {
-              maybeMarkCandidate(key);
+          if (n.isObjectPattern()) {
+            // Iterate through all the nodes in the object pattern
+            for (Node key = n.getFirstChild(); key != null; key = key.getNext()) {
+              if (key.isComputedProp()) {
+                // We don't want to rename computed properties
+                continue;
+              } else if (key.isQuotedString()) {
+                // Ensure that we never rename some other property in a way
+                // that could conflict with this quoted key.
+                quotedNames.add(key.getString());
+              } else if (compiler.getCodingConvention().blockRenamingForProperty(key.getString())) {
+                externedNames.add(key.getString());
+              } else {
+                maybeMarkCandidate(key);
+              }
             }
           }
           break;

diff --git a/test/com/google/javascript/jscomp/RenamePropertiesTest.java b/test/com/google/javascript/jscomp/RenamePropertiesTest.java
@@ -401,6 +401,10 @@ public void testPrototypePropertyForArrowFunction() {
         "Bar.prototype = {2: () => {}, a:    () => {}}; bar[2]();");
   }
 
+  public void testArrayDestructuring() {
+    testSame("var [first, second] = someArray");
+  }
+
   public void testDestructuredProperties() {
     // using destructuring shorthand
     test("var {   foo,   bar } = { foo: 1, bar: 2 }", "var { b:foo, a:bar } = {    b:1,    a:2 }");