Skip to content

Commit

Permalink
Update TODOs for clarity and re-enable one disabled test.
Browse files Browse the repository at this point in the history
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=191944101
  • Loading branch information
tbreisacher authored and lauraharker committed Apr 7, 2018
1 parent d4b81fd commit 63db5bd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/com/google/javascript/jscomp/IntegrationTest.java
Expand Up @@ -5118,8 +5118,7 @@ public void testInlineRestParam() {
+ "b[a-0]=arguments[a];return b[0]}(8))");
}

// TODO(b/69850796): Re-enable when InlineFunctions' FeatureSet is set back to ES6+.
public void disabled_testInlineRestParamNonTranspiling() {
public void testInlineRestParamNonTranspiling() {
CompilerOptions options = createCompilerOptions();
options.setLanguageIn(LanguageMode.ECMASCRIPT_2017);
options.setLanguageOut(LanguageMode.ECMASCRIPT_2017);
Expand Down Expand Up @@ -5198,7 +5197,7 @@ public void testDefaultParameters() {
"var a={a:9}; a=void 0===a?{a:5}:a;alert(3+a.a)");
}

// TODO(b/69850796): Re-enable when InlineFunctions' FeatureSet is set back to ES6+.
// TODO(b/69850796): Re-enable if/when InlineFunctions supports inlining default parameters
public void disabled_testDefaultParametersNonTranspiling() {
CompilerOptions options = createCompilerOptions();
CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
Expand Down Expand Up @@ -5237,7 +5236,8 @@ public void testRestObjectPatternParameters() {
"}(1,1,1,1,1))"));
}

// TODO(b/69850796): Re-enable when InlineFunctions' FeatureSet is set back to ES6+.
// TODO(b/69850796): Re-enable if/when InlineFunctions supports rest parameters that are
// object patterns.
public void disabled_testRestObjectPatternParametersNonTranspiling() {
CompilerOptions options = createCompilerOptions();
CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
Expand Down

0 comments on commit 63db5bd

Please sign in to comment.