Skip to content

Commit

Permalink
Creates the CHECK_STATIC_OVERRIDES diagnostic group.
Browse files Browse the repository at this point in the history
The group is empty/unused for now but will be populated in a follow-up. It's being created ahead of time so J2CL can preemptively use it as a hook for suppressing errors.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=239037243
  • Loading branch information
nreid260 authored and tjgq committed Mar 19, 2019
1 parent 1821dd0 commit 658b5cf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
6 changes: 6 additions & 0 deletions src/com/google/javascript/jscomp/DiagnosticGroups.java
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,12 @@ public DiagnosticGroup forName(String name) {
FunctionTypeBuilder.ALL_DIAGNOSTICS,
DiagnosticGroups.GLOBAL_THIS);

// TODO(b/112639311): Populate this group with appropriate diagnostics.
// This group isn't registered because it has no associated suppression. It's only ever referenced
// in Java code.
public static final DiagnosticGroup CHECK_STATIC_OVERRIDES =
new DiagnosticGroup("checkStaticOverrides_unregistered", UNUSED);

// Run the new type inference, but omit many warnings that are not
// found by the old type checker. This makes migration to NTI more manageable.
public static final DiagnosticGroup NEW_CHECK_TYPES_COMPATIBILITY_MODE =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ jsdoc.suppressions =\
checkEventfulObjectDisposal,\
checkPrototypalTypes,\
checkRegExp,\
checkStaticOverrides,\
checkTypes,\
checkVars,\
closureDepMethodUsageChecks,\
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/resources.json

Large diffs are not rendered by default.

0 comments on commit 658b5cf

Please sign in to comment.