Move the .i.js generation compiler pass to its own package

This requires making public a few NodeUtil utilities that were previously
package-private, but I think it's worth the tradeoff.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=179217544

src/com/google/javascript/jscomp/DefaultPassConfig.java

@@ -40,6 +40,7 @@
 import com.google.javascript.jscomp.ExtractPrototypeMemberDeclarations.Pattern;
 import com.google.javascript.jscomp.NodeTraversal.Callback;
 import com.google.javascript.jscomp.PassFactory.HotSwapPassFactory;
+import com.google.javascript.jscomp.ijs.ConvertToTypedInterface;
 import com.google.javascript.jscomp.lint.CheckArrayWithGoogObject;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;

src/com/google/javascript/jscomp/NodeUtil.java

@@ -1034,7 +1034,7 @@ static boolean isEnumDecl(Node n) {
    * /** @const * / var goog = goog || {};
    * /** @const * / goog.math = goog.math || {};
    */
-  static boolean isNamespaceDecl(Node n) {
+  public static boolean isNamespaceDecl(Node n) {
     JSDocInfo jsdoc = getBestJSDocInfo(n);
     if (jsdoc != null && !jsdoc.getTypeNodes().isEmpty()) {
       return false;
@@ -1814,7 +1814,7 @@ static boolean isSimpleFunctionDeclaration(Node fn) {
         && (isExprAssign(grandparent) || parent.isName());
   }
 
-  enum ValueType {
+  public enum ValueType {
     UNDETERMINED,
     NULL,
     VOID,
@@ -1828,7 +1828,7 @@ enum ValueType {
    * Apply the supplied predicate against
    * all possible result Nodes of the expression.
    */
-  static ValueType getKnownValueType(Node n) {
+  public static ValueType getKnownValueType(Node n) {
     switch (n.getToken()) {
       case CAST:
         return getKnownValueType(n.getFirstChild());
@@ -2715,7 +2715,7 @@ public boolean apply(Node n) {
           Token.NAMESPACE_ELEMENTS,
           Token.INTERFACE_MEMBERS);
 
-  static boolean isStatementParent(Node parent) {
+  public static boolean isStatementParent(Node parent) {
     // It is not possible to determine definitely if a node is a statement
     // or not if it is not part of the AST.  A FUNCTION node can be
     // either part of an expression or a statement.
@@ -3910,7 +3910,7 @@ private static void useSourceInfoForNewQName(Node newQName, Node basisNode) {
   /**
    * Gets the root node of a qualified name. Must be either NAME, THIS or SUPER.
    */
-  static Node getRootOfQualifiedName(Node qName) {
+  public static Node getRootOfQualifiedName(Node qName) {
     for (Node current = qName; true; current = current.getFirstChild()) {
       if (current.isName() || current.isThis() || current.isSuper()) {
         return current;
@@ -4129,7 +4129,7 @@ private static void getLhsNodesHelper(Node n, List<Node> lhsNodes) {
   }
 
   /** Retrieves lhs nodes declared in the current declaration or ASSIGN statement. */
-  static List<Node> findLhsNodesInNode(Node declNode) {
+  public static List<Node> findLhsNodesInNode(Node declNode) {
     checkArgument(
         isNameDeclaration(declNode)
             || declNode.isParamList()
@@ -5053,7 +5053,7 @@ private static boolean isToStringMethodCall(Node call) {
 
   /** Return declared JSDoc type for the given name declaration, or null if none present. */
   @Nullable
-  static JSTypeExpression getDeclaredTypeExpression(Node declaration) {
+  public static JSTypeExpression getDeclaredTypeExpression(Node declaration) {
     checkArgument(declaration.isName() || declaration.isStringKey());
     JSDocInfo nameJsdoc = getBestJSDocInfo(declaration);
     if (nameJsdoc != null) {
@@ -5080,7 +5080,7 @@ public static JSDocInfo getBestJSDocInfo(Node n) {
   }
 
   @Nullable
-  static Node getBestJSDocInfoNode(Node n) {
+  public static Node getBestJSDocInfoNode(Node n) {
     if (n.isExprResult()) {
       return getBestJSDocInfoNode(n.getFirstChild());
     }
@@ -5113,7 +5113,7 @@ static Node getBestJSDocInfoNode(Node n) {
   }
 
   /** Find the l-value that the given r-value is being assigned to. */
-  static Node getBestLValue(Node n) {
+  public static Node getBestLValue(Node n) {
     Node parent = n.getParent();
     boolean isFunctionDeclaration = isFunctionDeclaration(n);
     if (isFunctionDeclaration) {
@@ -5136,7 +5136,7 @@ static Node getBestLValue(Node n) {
   }
 
   /** Gets the r-value (or initializer) of a node returned by getBestLValue. */
-  static Node getRValueOfLValue(Node n) {
+  public static Node getRValueOfLValue(Node n) {
     Node parent = n.getParent();
     switch (parent.getToken()) {
       case ASSIGN:
@@ -5546,7 +5546,7 @@ static void markNewScopesChanged(Node node, AbstractCompiler compiler) {
   }
 
   /** Recurses through a tree, marking all function nodes deleted. */
-  static void markFunctionsDeleted(Node node, AbstractCompiler compiler) {
+  public static void markFunctionsDeleted(Node node, AbstractCompiler compiler) {
     if (node.isFunction()) {
       compiler.reportFunctionDeleted(node);
     }

src/com/google/javascript/jscomp/Var.java

@@ -197,7 +197,7 @@ boolean isParam() {
     return declarationType() == Token.PARAM_LIST;
   }
 
-  boolean isDefaultParam() {
+  public boolean isDefaultParam() {
     Node parent = nameNode.getParent();
     return parent.getParent().isParamList() && parent.isDefaultValue()
         && parent.getFirstChild() == nameNode;

src/com/google/javascript/jscomp/ConvertToTypedInterface.java → src/com/google/javascript/jscomp/ijs/ConvertToTypedInterface.java

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package com.google.javascript.jscomp;
+package com.google.javascript.jscomp.ijs;
 
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
@@ -25,7 +25,15 @@
 import com.google.common.collect.ListMultimap;
 import com.google.common.collect.MultimapBuilder;
 import com.google.common.collect.Ordering;
+import com.google.javascript.jscomp.AbstractCompiler;
+import com.google.javascript.jscomp.CompilerPass;
+import com.google.javascript.jscomp.DiagnosticType;
+import com.google.javascript.jscomp.JSError;
+import com.google.javascript.jscomp.NodeTraversal;
 import com.google.javascript.jscomp.NodeTraversal.AbstractShallowStatementCallback;
+import com.google.javascript.jscomp.NodeUtil;
+import com.google.javascript.jscomp.Scope;
+import com.google.javascript.jscomp.Var;
 import com.google.javascript.rhino.IR;
 import com.google.javascript.rhino.JSDocInfo;
 import com.google.javascript.rhino.JSDocInfo.Visibility;
@@ -53,7 +61,7 @@
  *
  * @author blickly@google.com (Ben Lickly)
  */
-class ConvertToTypedInterface implements CompilerPass {
+public class ConvertToTypedInterface implements CompilerPass {
 
   static final DiagnosticType CONSTANT_WITHOUT_EXPLICIT_TYPE =
       DiagnosticType.warning(
@@ -71,7 +79,7 @@ class ConvertToTypedInterface implements CompilerPass {
 
   private final AbstractCompiler compiler;
 
-  ConvertToTypedInterface(AbstractCompiler compiler) {
+  public ConvertToTypedInterface(AbstractCompiler compiler) {
     this.compiler = compiler;
   }
 
@@ -100,7 +108,8 @@ public void processFile(Node scriptNode) {
     new SimplifyDeclarations(compiler, currentFile).simplifyAll();
   }
 
-  private static @Nullable Var findNameDeclaration(Scope scope, Node rhs) {
+  @Nullable
+  private static Var findNameDeclaration(Scope scope, Node rhs) {
     if (!rhs.isName()) {
       return null;
     }

test/com/google/javascript/jscomp/ConvertToTypedInterfaceTest.java → test/com/google/javascript/jscomp/ijs/ConvertToTypedInterfaceTest.java

@@ -14,9 +14,12 @@
  * limitations under the License.
  */
 
-package com.google.javascript.jscomp;
+package com.google.javascript.jscomp.ijs;
 
+import com.google.javascript.jscomp.Compiler;
 import com.google.javascript.jscomp.CompilerOptions.LanguageMode;
+import com.google.javascript.jscomp.CompilerPass;
+import com.google.javascript.jscomp.CompilerTestCase;
 
 /** Unit tests for {@link ConvertToTypedInterface}. */
 public final class ConvertToTypedInterfaceTest extends CompilerTestCase {