Refactor CompilerTestCase to use classes objects to describe the parts.

This makes it possible to support "one-off" cases without confusing overloads. This change doesn't yet cover all test variants (module inputs, checking extern changes) which would allow additional variants to be removed, nor does it attempt to remove the cleanup of removing the less common variants of test/testSame/etc which would ultimately be the goal. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158400843
google · Jun 9, 2017 · 6954648 · 6954648
1 parent 3617803
commit 6954648
Show file tree

Hide file tree

Showing 65 changed files with 1,169 additions and 1,209 deletions.
diff --git a/test/com/google/javascript/jscomp/AggressiveInlineAliasesTest.java b/test/com/google/javascript/jscomp/AggressiveInlineAliasesTest.java
@@ -47,27 +47,23 @@ protected void setUp() throws Exception {
   }
 
   public void test_b19179602() {
-    test(
-        LINE_JOINER.join(
-            "var a = {};",
-            "/** @constructor */ a.b = function() {};",
-            "a.b.staticProp = 5;",
-            "/** @constructor */",
-            "function f() { ",
-            "  while (true) { ",
-            "    var b = a.b;",
-            "    alert(b.staticProp); } }"),
-        LINE_JOINER.join(
-            "var a = {};",
-            "/** @constructor */ a.b = function() {};",
-            "a.b.staticProp = 5;",
-            "/** @constructor */",
-            "function f() {",
-            "  for(; true; ) {",
-            "    var b = a.b;",
-            "    alert(b.staticProp); } }"),
-        null,
-        AggressiveInlineAliases.UNSAFE_CTOR_ALIASING);
+    test(LINE_JOINER.join(
+    "var a = {};",
+    "/** @constructor */ a.b = function() {};",
+    "a.b.staticProp = 5;",
+    "/** @constructor */",
+    "function f() { ",
+    "  while (true) { ",
+    "    var b = a.b;",
+    "    alert(b.staticProp); } }"), LINE_JOINER.join(
+    "var a = {};",
+    "/** @constructor */ a.b = function() {};",
+    "a.b.staticProp = 5;",
+    "/** @constructor */",
+    "function f() {",
+    "  for(; true; ) {",
+    "    var b = a.b;",
+    "    alert(b.staticProp); } }"), warning(AggressiveInlineAliases.UNSAFE_CTOR_ALIASING));
   }
 
   public void test_b19179602_declareOutsideLoop() {

diff --git a/test/com/google/javascript/jscomp/AmbiguatePropertiesTest.java b/test/com/google/javascript/jscomp/AmbiguatePropertiesTest.java
@@ -447,7 +447,7 @@ public void testSetPropertyOfGlobalThis() {
   }
 
   public void testReadPropertyOfGlobalThis() {
-    testSame("Object.prototype.prop;", "f(this.prop);", null);
+    testSame("Object.prototype.prop;", "f(this.prop);");
   }
 
   public void testSetQuotedPropertyOfThis() {