Skip to content

Commit

Permalink
Document that BANNED_NAME does not work for banning names defined in …
Browse files Browse the repository at this point in the history
…a goog.module().

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207810387
  • Loading branch information
bangert authored and tjgq committed Aug 10, 2018
1 parent b996efb commit 6b2e4ae
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/com/google/javascript/jscomp/conformance.proto
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ message Requirement {
// - A global name like "eval" or "goog"
// - A namespaced value or type: namespace.Banned
// - A 'static' property: "namespace.Foo.banned"
// TODO(b/112325992): If namespace.Banned is a goog.module that does not
// call goog.module.declareNamespace, the rule will not match.
BANNED_NAME = 3;

// A banned instance property, for example:
Expand Down

0 comments on commit 6b2e4ae

Please sign in to comment.