[NTI] Implement FunctionTypeI#hasProperties() in NTI. Note that this …

…is a small change to the OTI behavior, since previously it would return true based on a lazily-initialized prototype property, but since function prototypes are eagerly initialized in NTI and nobody was depending on that specific detail, it's been changed for compatibility.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=165060640

src/com/google/javascript/jscomp/newtypes/JSType.java

@@ -1936,7 +1936,8 @@ public final List<String> getTypeParameters() {
 
   @Override
   public final boolean hasProperties() {
-    throw new UnsupportedOperationException("hasProperties not implemented yet");
+    checkState(this.isFunctionType());
+    return getObjTypeIfSingletonObj().isFunctionWithProperties();
   }
 
   @Override

src/com/google/javascript/rhino/FunctionTypeI.java

@@ -80,13 +80,12 @@ public interface FunctionTypeI extends TypeI {
    * This is only valid for constructors and interfaces, and will not be
    * null. This allows a downward traversal of the subtype graph.
    */
-  // TODO(sdh): change the name to getDirectSubTypes()
   Iterable<FunctionTypeI> getDirectSubTypes();
 
   /** Gets the type of {@code this} in this function. */
   TypeI getTypeOfThis();
 
-  /** Whether this FunctionTypeI is a function with properties. */
+  /** Whether this function type has any properties (not counting "prototype"). */
   boolean hasProperties();
 
   void setSource(Node n);

src/com/google/javascript/rhino/jstype/FunctionType.java

@@ -1425,9 +1425,6 @@ public TypeI convertMethodToFunction() {
 
   @Override
   public boolean hasProperties() {
-    if (prototypeSlot != null) {
-      return true;
-    }
     return !super.getOwnPropertyNames().isEmpty();
   }