Allow command line option control for CommonJS module loading errors.

Closes #2056 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135125911
google · Oct 5, 2016 · 98ffc24 · 98ffc24
1 parent 6d1c49d
commit 98ffc24
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/com/google/javascript/jscomp/DiagnosticGroups.java b/src/com/google/javascript/jscomp/DiagnosticGroups.java
@@ -98,6 +98,7 @@ public DiagnosticGroup forName(String name) {
   static final String DIAGNOSTIC_GROUP_NAMES =
       "accessControls, ambiguousFunctionDecl, checkEventfulObjectDisposal, "
       + "checkRegExp, checkTypes, checkVars, "
+      + "commonJsModuleLoad, "
       + "conformanceViolations, const, constantProperty, deprecated, "
       + "deprecatedAnnotations, duplicateMessage, es3, "
       + "es5Strict, externsValidation, fileoverviewTags, globalThis, "
@@ -110,6 +111,10 @@ public DiagnosticGroup forName(String name) {
       + "unusedLocalVariables, unusedPrivateMembers, uselessCode, "
       + "useOfGoogBase, underscore, visibility";
 
+  public static final DiagnosticGroup COMMON_JS_MODULE_LOAD =
+      DiagnosticGroups.registerGroup(
+          "commonJsModuleLoad", ProcessCommonJSModules.COMMON_JS_MODULE_LOAD_ERROR);
+
   public static final DiagnosticGroup GLOBAL_THIS =
       DiagnosticGroups.registerGroup("globalThis",
           CheckGlobalThis.GLOBAL_THIS);

diff --git a/src/com/google/javascript/jscomp/ProcessCommonJSModules.java b/src/com/google/javascript/jscomp/ProcessCommonJSModules.java
@@ -43,7 +43,7 @@ public final class ProcessCommonJSModules implements CompilerPass {
   private static final String EXPORTS = "exports";
   private static final String MODULE = "module";
 
-  private static final DiagnosticType LOAD_ERROR = DiagnosticType.error(
+  public static final DiagnosticType COMMON_JS_MODULE_LOAD_ERROR = DiagnosticType.error(
       "JSC_COMMONJS_MODULE_LOAD_ERROR",
       "Failed to load module \"{0}\"");
 
@@ -323,7 +323,7 @@ private void visitRequireCall(NodeTraversal t, Node require, Node parent) {
       String requireName = require.getSecondChild().getString();
       ModulePath modulePath = t.getInput().getPath().resolveCommonJsModule(requireName);
       if (modulePath == null) {
-        compiler.report(t.makeError(require, LOAD_ERROR, requireName));
+        compiler.report(t.makeError(require, COMMON_JS_MODULE_LOAD_ERROR, requireName));
         return;
       }
 
@@ -716,7 +716,7 @@ private void fixTypeNode(NodeTraversal t, Node typeNode) {
           String moduleName = name.substring(0, endIndex);
           ModulePath modulePath = t.getInput().getPath().resolveCommonJsModule(moduleName);
           if (modulePath == null) {
-            t.makeError(typeNode, LOAD_ERROR, moduleName);
+            t.makeError(typeNode, COMMON_JS_MODULE_LOAD_ERROR, moduleName);
             return;
           }