Skip to content

Commit

Permalink
Reword a TODO that was implying that OTI would eventually be deleted.
Browse files Browse the repository at this point in the history
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=189626450
  • Loading branch information
tbreisacher authored and brad4d committed Mar 20, 2018
1 parent f0c2996 commit 999cffe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions externs/es3.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,12 @@ Arguments.prototype.caller;
Arguments.prototype.length;

/**
* Not actually a global variable, but we need it in order for the current type
* checker to typecheck the "arguments" variable in a function correctly.
* TODO(tbreisacher): When the old type checker is gone, delete this and add
* an 'arguments' variable of type Array<string> in the d8 externs.
* Not actually a global variable, when running in a browser environment. But
* we need it in order for the type checker to typecheck the "arguments"
* variable in a function correctly.
*
* TODO(tbreisacher): There should be a separate 'arguments' variable of type
* `Array<string>`, in the d8 externs.
*
* @type {!Arguments}
* @see http://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Functions_and_function_scope/arguments
Expand Down
2 changes: 1 addition & 1 deletion src/com/google/javascript/jscomp/resources.json

Large diffs are not rendered by default.

0 comments on commit 999cffe

Please sign in to comment.