[NTI] Suppress CheckAccessControls const warnings when run with NTI.

Users opting into NTI will likely prefer the stricter const checks that
NTI provides over those of CheckAccessControls.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=128632773

src/com/google/javascript/jscomp/Compiler.java

@@ -371,6 +371,9 @@ protected void reconcileOptionsWithGuards() {
     // But we do not want to see the warnings from OTI.
     if (options.getNewTypeInference() && options.getRunOTIAfterNTI()) {
       options.checkTypes = true;
+      // Supress warnings from the const checks of CheckAccessControls so as to avoid
+      // duplication.
+      options.setWarningLevel(DiagnosticGroups.ACCESS_CONTROLS_CONST, CheckLevel.OFF);
       if (!options.reportOTIErrorsUnderNTI) {
         options.setWarningLevel(
             DiagnosticGroups.OLD_CHECK_TYPES,

src/com/google/javascript/jscomp/CompilerOptions.java

@@ -147,6 +147,14 @@ public boolean shouldGenerateTypedExterns() {
 
   private boolean useNewTypeInference;
 
+  /**
+   * When this flag is enabled, we run OTI after NTI so that the AST is annotated with the old types
+   * instead of the new and susbsequent passes that use type information continue to get it from
+   * the old types. When disabled, we don't run OTI at all, so the AST stays annotated
+   * with the new types, and that is what subsequent passes use. It should only ever be disabled in
+   * tests that want to verify that a pass works with the new types.
+   * TODO(aravindpg): move this flag into CompilerTestCase in some form.
+   */
   private boolean runOTIAfterNTI = true;
 
   /**

src/com/google/javascript/jscomp/DiagnosticGroups.java

@@ -351,6 +351,11 @@ public DiagnosticGroup forName(String name) {
           NewTypeInference.CONST_PROPERTY_REASSIGNED,
           NewTypeInference.CONST_PROPERTY_DELETED);
 
+  static final DiagnosticGroup ACCESS_CONTROLS_CONST =
+      DiagnosticGroups.registerGroup("accessControlsConst",
+          CheckAccessControls.CONST_PROPERTY_DELETED,
+          CheckAccessControls.CONST_PROPERTY_REASSIGNED_VALUE);
+
   public static final DiagnosticGroup CONSTANT_PROPERTY =
       DiagnosticGroups.registerGroup("constantProperty",
           CheckAccessControls.CONST_PROPERTY_DELETED,

test/com/google/javascript/jscomp/IntegrationTest.java

@@ -778,6 +778,19 @@ public void testBothTypeCheckersRunNoDupWarning() {
             "})();"));
   }
 
+  public void testNTIConstWarningsOverrideAccessControls() {
+    CompilerOptions options = createCompilerOptions();
+    options.setCheckTypes(true);
+    String js =
+        LINE_JOINER.join(
+            "/** @constructor */ function Foo(name) {}",
+            "/** @const */ Foo.prop = 1;",
+            "Foo.prop = 2;");
+    test(options, js, CheckAccessControls.CONST_PROPERTY_REASSIGNED_VALUE);
+    options.setNewTypeInference(true);
+    test(options, js, NewTypeInference.CONST_PROPERTY_REASSIGNED);
+  }
+
   public void testNTInoMaskTypeParseError() {
     CompilerOptions options = createCompilerOptions();
     options.setCheckTypes(true);