Automated g4 rollback of changelist 163392994.

*** Reason for rollback *** Can cause a crash for some code *** Original change description *** Add ES8_MODULES feature set method for renameProperties pass *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=163496710
google · Jul 31, 2017 · 9fc3fe4 · 9fc3fe4
1 parent 8fc8229
commit 9fc3fe4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/src/com/google/javascript/jscomp/DefaultPassConfig.java b/src/com/google/javascript/jscomp/DefaultPassConfig.java
@@ -2964,12 +2964,6 @@ public void process(Node externs, Node root) {
             }
           };
         }
-
-        @Override
-        protected FeatureSet featureSet() {
-          // This pass requires gatherExternProperties to run before it can run
-          return ES8_MODULES;
-        }
       };
 
   /** Renames variables. */

diff --git a/test/com/google/javascript/jscomp/IntegrationTest.java b/test/com/google/javascript/jscomp/IntegrationTest.java
@@ -4385,8 +4385,6 @@ public void testDefaultParametersNonTranspiling() {
     CompilationLevel.ADVANCED_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
     options.setLanguageIn(LanguageMode.ECMASCRIPT_2017);
 
-    // For this test, coalesce variables runs followed by rename properties to produce the following
-    // variable/property names.
     test(
         options,
         LINE_JOINER.join(
@@ -4396,7 +4394,7 @@ public void testDefaultParametersNonTranspiling() {
             "alert(foo(3, {foo: 9}));"),
         LINE_JOINER.join(
             "{}",
-            "alert(3 + {a:9}.a);"));
+            "alert(3 + {foo:9}.foo);"));
   }
 
   public void testRestObjectPatternParameters() {