Allow cast nodes as valid operands for prefix and postfix operators.

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=162797421
google · Jul 25, 2017 · b102fff · b102fff
1 parent c0b1733
commit b102fff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/com/google/javascript/jscomp/parsing/IRFactory.java b/src/com/google/javascript/jscomp/parsing/IRFactory.java
@@ -1952,7 +1952,8 @@ Node processUpdateExpression(UpdateExpressionTree updateExpr) {
     }
 
     private Node createUpdateNode(Token type, boolean postfix, Node operand) {
-      if (!operand.isValidAssignmentTarget()) {
+      Node assignTarget = operand.isCast() ? operand.getFirstChild() : operand;
+      if (!assignTarget.isValidAssignmentTarget()) {
         errorReporter.error(
             SimpleFormat.format("Invalid %s %s operand.",
                 (postfix ? "postfix" : "prefix"),

diff --git a/test/com/google/javascript/jscomp/parsing/ParserTest.java b/test/com/google/javascript/jscomp/parsing/ParserTest.java
@@ -1052,6 +1052,7 @@ public void testPostfixExpression() {
     parse("a++");
     parse("a.b--");
     parse("a[0]++");
+    parse("/** @type {number} */ (a)++;");
 
     parseError("a()++", "Invalid postfix increment operand.");
     parseError("(new C)--", "Invalid postfix decrement operand.");
@@ -1060,6 +1061,7 @@ public void testPostfixExpression() {
     parseError("(+a)++", "Invalid postfix increment operand.");
     parseError("[1,2]++", "Invalid postfix increment operand.");
     parseError("'literal'++", "Invalid postfix increment operand.");
+    parseError("/** @type {number} */ (a())++;", "Invalid postfix increment operand.");
   }
 
   public void testUnaryExpression() {