Support Assign Exponent in NTI.

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=163361548
google · Jul 28, 2017 · b6c9eed · b6c9eed
1 parent 861c32b
commit b6c9eed
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/com/google/javascript/jscomp/NewTypeInference.java b/src/com/google/javascript/jscomp/NewTypeInference.java
@@ -1428,6 +1428,7 @@ private EnvTypePair analyzeExprFwd(
       case ASSIGN_MUL:
       case ASSIGN_DIV:
       case ASSIGN_MOD:
+      case ASSIGN_EXPONENT:
         resultPair = analyzeAssignNumericOpFwd(expr, inEnv);
         break;
       case SHEQ:
@@ -3614,6 +3615,7 @@ private EnvTypePair analyzeExprBwd(
       case ASSIGN_MUL:
       case ASSIGN_DIV:
       case ASSIGN_MOD:
+      case ASSIGN_EXPONENT:
         return analyzeAssignNumericOpBwd(expr, outEnv);
       case GETPROP:
         {

diff --git a/test/com/google/javascript/jscomp/NewTypeInferenceTest.java b/test/com/google/javascript/jscomp/NewTypeInferenceTest.java
@@ -13816,6 +13816,35 @@ public void testExponent() {
         "var /** number */ n = 1 ** NaN;");
   }
 
+  public void testAssignExponent() {
+    typeCheck(LINE_JOINER.join(
+        "function f(/** number */ x) {",
+        "  x **= 1;",
+        "}"));
+
+    typeCheck(LINE_JOINER.join(
+        "function f(/** * */ x) {",
+        "  x **= 1;",
+        "}"),
+        NewTypeInference.INVALID_OPERAND_TYPE);
+
+    typeCheck(LINE_JOINER.join(
+        "function f(/** number */ x) {",
+        "  x **= '';",
+        "}"),
+        NewTypeInference.INVALID_OPERAND_TYPE);
+
+    typeCheck(LINE_JOINER.join(
+        "function f(/** !Number */ x) {",
+        "  x **= 1;",
+        "}"));
+
+    typeCheck(LINE_JOINER.join(
+        "function f(/** number */ x) {",
+        "  x **= NaN;",
+        "}"));
+  }
+
   public void testUndefinedFunctionCtorNoCrash() {
     typeCheckCustomExterns("", "function f(x) {}",
         GlobalTypeInfoCollector.FUNCTION_CONSTRUCTOR_NOT_DEFINED);