Report all warnings that can be auto-fixed, including lint warnings s…

…o that the "fix compiler errors" refactoring will fix them. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=140785626
google · Dec 2, 2016 · cbf6153 · cbf6153
1 parent ddc1059
commit cbf6153
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 2 deletions.
diff --git a/src/com/google/javascript/refactoring/RefactoringDriver.java b/src/com/google/javascript/refactoring/RefactoringDriver.java
@@ -92,7 +92,7 @@ private Compiler createCompiler(
   @VisibleForTesting
   public static CompilerOptions getCompilerOptions() {
     CompilerOptions options = new CompilerOptions();
-    options.setLanguageIn(LanguageMode.ECMASCRIPT6);
+    options.setLanguageIn(LanguageMode.ECMASCRIPT_NEXT);
     options.setLanguageOut(LanguageMode.ECMASCRIPT5);
     options.setSummaryDetailLevel(0);
 
@@ -110,7 +110,9 @@ public static CompilerOptions getCompilerOptions() {
     options.setGenerateExports(true);
     options.setPreserveGoogProvidesAndRequires(true);
 
-    options.setWarningLevel(DiagnosticGroups.MISSING_REQUIRE, CheckLevel.ERROR);
+    options.setWarningLevel(DiagnosticGroups.STRICT_MISSING_REQUIRE, CheckLevel.WARNING);
+    options.setWarningLevel(DiagnosticGroups.EXTRA_REQUIRE, CheckLevel.WARNING);
+    options.setWarningLevel(DiagnosticGroups.LINT_CHECKS, CheckLevel.WARNING);
 
     return options;
   }

diff --git a/test/com/google/javascript/refactoring/examples/testdata/navigational_xss_sinks_test_in.js b/test/com/google/javascript/refactoring/examples/testdata/navigational_xss_sinks_test_in.js
@@ -21,6 +21,7 @@
 
 goog.provide('refactoring_testcase');
 
+/** @suppress {extraRequire} */
 goog.require('test_dependency');
 
 //

diff --git a/test/com/google/javascript/refactoring/examples/testdata/navigational_xss_sinks_test_out.js b/test/com/google/javascript/refactoring/examples/testdata/navigational_xss_sinks_test_out.js
@@ -23,6 +23,7 @@ goog.provide('refactoring_testcase');
 
 goog.require('goog.asserts');
 goog.require('goog.dom.safe');
+/** @suppress {extraRequire} */
 goog.require('test_dependency');
 
 //

diff --git a/test/com/google/javascript/refactoring/examples/testdata/set_location_href_test_in.js b/test/com/google/javascript/refactoring/examples/testdata/set_location_href_test_in.js
@@ -18,6 +18,7 @@
 
 goog.provide('refactoring_testcase');
 
+/** @suppress {extraRequire} */
 goog.require('test_dependency');
 
 /**

diff --git a/test/com/google/javascript/refactoring/examples/testdata/set_location_href_test_out.js b/test/com/google/javascript/refactoring/examples/testdata/set_location_href_test_out.js
@@ -19,6 +19,7 @@
 goog.provide('refactoring_testcase');
 
 goog.require('goog.dom.safe');
+/** @suppress {extraRequire} */
 goog.require('test_dependency');
 
 /**