Skip to content

Commit

Permalink
[NTI] Fix some TODOs in PolymerPassTest.
Browse files Browse the repository at this point in the history
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=171634699
  • Loading branch information
dimvar authored and Tyler Breisacher committed Oct 10, 2017
1 parent cd73376 commit f1de2f8
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions test/com/google/javascript/jscomp/PolymerPassTest.java
Expand Up @@ -251,17 +251,15 @@ public void testDefaultTypeNameTarget() {
}

public void testPathAssignmentTarget() {
// TODO(sdh): Figure out why `x` is not a namespace in the root scope
this.mode = TypeInferenceMode.OTI_ONLY;
test(
LINE_JOINER.join(
"/** const */ var x = {};",
"/** @const */ var x = {};",
"x.Z = Polymer({",
" is: 'x-element',",
"});"),

LINE_JOINER.join(
"/** const */ var x = {};",
"/** @const */ var x = {};",
"/** @constructor @extends {PolymerElement} @implements {Polymerx_ZInterface} */",
"x.Z = function() {};",
"x.Z = Polymer(/** @lends {x.Z.prototype} */ {",
Expand Down Expand Up @@ -309,11 +307,9 @@ public void testComputedPropName() {
* type to the global namespace.
*/
public void testIIFEExtractionInGlobalNamespace() {
// TODO(sdh): Figure out why `x` is not a namespace in the root scope
this.mode = TypeInferenceMode.OTI_ONLY;
test(
LINE_JOINER.join(
"/** const */ var x = {};",
"/** @const */ var x = {};",
"(function() {",
" x.Z = Polymer({",
" is: 'x-element',",
Expand All @@ -322,7 +318,7 @@ public void testIIFEExtractionInGlobalNamespace() {
"})()"),

LINE_JOINER.join(
"/** const */ var x = {};",
"/** @const */ var x = {};",
"(function() {",
" /** @constructor @extends {PolymerElement} @implements {Polymerx_ZInterface}*/",
" x.Z = function() {};",
Expand Down

0 comments on commit f1de2f8

Please sign in to comment.