Add tests to repro issues around interface properties declared in ES6…

… class constructor. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=246273225
google · May 2, 2019 · f65e40c · f65e40c
1 parent 92541e5
commit f65e40c
Show file tree

Hide file tree

Showing 2 changed files with 73 additions and 0 deletions.
diff --git a/test/com/google/javascript/jscomp/DisambiguatePropertiesTest.java b/test/com/google/javascript/jscomp/DisambiguatePropertiesTest.java
@@ -30,6 +30,7 @@
 import java.util.TreeMap;
 import java.util.TreeSet;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -1314,6 +1315,34 @@ public void testInterface() {
     testSets(js, "{a=[[Foo.prototype, I.prototype]]}");
   }
 
+  // TODO(b/131257037): Support ES6 style instance properties on interfaces.
+  @Ignore
+  @Test
+  public void testInterface_es6() {
+    testSets(
+        lines(
+            "/** @interface */ class I { constructor(){ this.a; } };",
+            "/** @implements {I} */ class Foo {};",
+            "Foo.prototype.a;",
+            "/** @type {I} */",
+            "var f = new Foo;",
+            "var x = f.a;"),
+        "{a=[[Foo.prototype, I.prototype]]}");
+  }
+
+  @Test
+  public void testInterface_es6withTypeDeclaration() {
+    testSets(
+        lines(
+            "/** @interface */ class I { constructor(){ /** @type {number} */ this.a; } };",
+            "/** @implements {I} */ class Foo {};",
+            "Foo.prototype.a;",
+            "/** @type {I} */",
+            "var f = new Foo;",
+            "var x = f.a;"),
+        "{a=[[Foo.prototype, I.prototype]]}");
+  }
+
   @Test
   public void testInterface_noDirectImplementors() {
     String js = ""

diff --git a/test/com/google/javascript/jscomp/TypeCheckTest.java b/test/com/google/javascript/jscomp/TypeCheckTest.java
@@ -6171,6 +6171,50 @@ public void testGetprop4() {
         "required: Object");
   }
 
+  @Test
+  public void testGetrop_interfaceWithoutTypeDeclaration() {
+    testTypes(
+        lines(
+            "/** @interface */var I = function() {};",
+            // Note that we didn't declare the type but we still expect JsCompiler to recognize the
+            // property.
+            "I.prototype.foo;",
+            "var v = /** @type {I} */ (null); ",
+            "v.foo = 5;"));
+  }
+
+  @Test
+  public void testGetrop_interfaceEs6WithoutTypeDeclaration() {
+    testTypes(
+        lines(
+            "/** @interface */",
+            "class I {",
+            "  constructor() {",
+            "    this.foo;",
+            "  }",
+            "}",
+            "var v = /** @type {I} */ (null); ",
+            "v.foo = 5;"),
+        // TODO(b/131257037): Support ES6 style instance properties on interfaces.
+        new String[] {
+          "Property foo never defined on I", ILLEGAL_PROPERTY_CREATION_MESSAGE,
+        });
+  }
+
+  @Test
+  public void testGetrop_interfaceEs6WithTypeDeclaration() {
+    testTypes(
+        lines(
+            "/** @interface */",
+            "class I {",
+            "  constructor() {",
+            "    /** @type {number} */ this.foo;",
+            "  }",
+            "}",
+            "var v = /** @type {I} */ (null); ",
+            "v.foo = 5;"));
+  }
+
   @Test
   public void testSetprop1() {
     // Create property on struct in the constructor