[NTI] Improve InlineProperties in NTI-only build, to match OTI.

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=173940373
google · Oct 31, 2017 · ffb2649 · ffb2649
1 parent a933e16
commit ffb2649
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/com/google/javascript/jscomp/InlineProperties.java b/src/com/google/javascript/jscomp/InlineProperties.java
@@ -188,6 +188,9 @@ private void invalidateProperty(String propName) {
      */
     private boolean maybeStoreCandidateValue(TypeI type, String propName, Node value) {
       checkNotNull(value);
+      if (type.toMaybeObjectType() != null) {
+        type = type.toMaybeObjectType().withoutStrayProperties();
+      }
       if (!props.containsKey(propName)
           && !invalidatingTypes.isInvalidating(type)
           && NodeUtil.isImmutableValue(value)

diff --git a/test/com/google/javascript/jscomp/InlinePropertiesTest.java b/test/com/google/javascript/jscomp/InlinePropertiesTest.java
@@ -174,6 +174,28 @@ public void testConstInstanceProp4() {
         "new C().foo;\n"));
   }
 
+  public void testConstInstanceProp5() {
+    test(
+        LINE_JOINER.join(
+            "/** @constructor */",
+            "function Foo() {",
+            "  /** @type {?number} */",
+            "  this.a = 1;",
+            "  /** @type {number} */",
+            "  this.b = 2;",
+            "}",
+            "var x = (new Foo).b;"),
+        LINE_JOINER.join(
+            "/** @constructor */",
+            "function Foo() {",
+            "  /** @type {?number} */",
+            "  this.a = 1;",
+            "  /** @type {number} */",
+            "  this.b = 2;",
+            "}",
+            "var x = (new Foo, 2);"));
+  }
+
 
   public void testConstClassProps1() {
     // Inline constant class properties,